Incorrect code sample of update method in readme.md #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #720 +/- ##
=======================================
Coverage 90.89% 90.89%
=======================================
Files 71 71
Lines 3414 3414
=======================================
Hits 3103 3103
Misses 311 311 ☔ View full report in Codecov by Sentry. |
|
Thank you! Could you please rebase the branch on master? |
…/dynamoid into update-sample-incorrect-in-readme
|
I’m sorry. Is this correct? |
|
Could you please squash all commits into one? I would do it myself and push with force into your branch but it seems it's not permitted. |
remove code sample that not exist as specifications in update method. remove code sample that not exist as specifications in update method. remove code sample that not exist as specifications in update method. remove code sample that not exist as specifications in update method.
…/dynamoid into update-sample-incorrect-in-readme
|
I'm sorry but I accidentaly broke branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for maintenance of this gem.
Probably related to issue #657.
I found what incorrect code sample of update method in readme.md.
.updatemethod does not accept conditions as arguments.dynamoid/lib/dynamoid/persistence.rb
Line 232 in 6b96d1d
Therefore, the following code as shown in the sample will fail.
So I removed this code sample.
thank you!